Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove epoch_finish timestamp from release & Update actions #147

Merged

Conversation

Cubik65536
Copy link
Member

@Cubik65536 Cubik65536 commented Jan 30, 2024

This PR contains:

  • The removal of epoch_finish timestamp from the release (tag, release title, release body) (as discussed in A small suggestion for the Release Notes #146).
  • Update @actions/upload-artifact and @actions/download-artifact to v4 (so Node.js 20 will be used as Node.js 16 used in v3 is deprecated).
  • @actions/checkout to v4 (so Node.js 20 will be used as Node.js 16 used in v3 is deprecated).
  • Update to ungoogled-chromium 121.0.6167.139

No modification aside from the submodule bump is needed.


Builds and runs fine locally.

SCR-20240203-ihyg

@Cubik65536 Cubik65536 force-pushed the ci/new-tag-and-artifact-action branch from 6619cd4 to fdb2d13 Compare January 30, 2024 18:36
Signed-off-by: Qian Qian "Cubik"‎ <[email protected]>
@Cubik65536 Cubik65536 changed the title ci: Remove epoch_finish timestamp from release & Update artifact upload/download actions [WIP] ci: Remove epoch_finish timestamp from release & Update actions [WIP] Jan 31, 2024
Signed-off-by: Qian Qian "Cubik"‎ <[email protected]>
@Cubik65536 Cubik65536 marked this pull request as ready for review February 1, 2024 18:46
@Cubik65536
Copy link
Member Author

Now ready for review, the test release coming with these changes is here.

P.S.: 121.0.6167.139-1 is coming, I'll work on it this weekend.

@Cubik65536 Cubik65536 changed the title ci: Remove epoch_finish timestamp from release & Update actions [WIP] ci: Remove epoch_finish timestamp from release & Update actions Feb 1, 2024
@Cubik65536
Copy link
Member Author

@claudiodekker You might be interested in knowing these changes in advance so you can prepare for it on your end. This one will stay here for a longer time :D

@claudiodekker
Copy link

claudiodekker commented Feb 1, 2024

@Cubik65536 Ha, thanks for the heads-up! I already saw it but when I did it was still in WIP/Draft state, but I'll make sure to get things ready 👍

@Cubik65536 Cubik65536 linked an issue Feb 2, 2024 that may be closed by this pull request
@PF4Public
Copy link
Contributor

  • @actions/checkout to v4 (so Node.js 20 will be used as Node.js 16 used in v3 is deprecated).

Would it make sense to adopt Dependabot to bump this kind of things automatically in the future?

@claudiodekker
Copy link

claudiodekker commented Feb 3, 2024

@PF4Public I wouldn't. Typically these constitute "major" version changes, meaning that options can change. Github's actions have been pretty stable in that they're mostly drop-in replacements/upgrades, but I've seen certain options/flags change in the past.

For example Removed input "submodules" in https://github.com/actions/checkout/releases/tag/v2.0.0

@PF4Public
Copy link
Contributor

@claudiodekker Well, I should've written "semi-automatic" :) Dependabot only creates PRs with changes, here are examples: https://github.com/nodejs/node/pulls/app%2Fdependabot

@claudiodekker
Copy link

claudiodekker commented Feb 3, 2024

@PF4Public Ah, right, yeah I misunderstood. I thought you meant doing something like this to auto-merge minor/patch-level changes: https://github.com/claudiodekker/word-generator/blob/master/.github/workflows/dependabot-auto-merge.yml

@Cubik65536
Copy link
Member Author

  • @actions/checkout to v4 (so Node.js 20 will be used as Node.js 16 used in v3 is deprecated).

Would it make sense to adopt Dependabot to bump this kind of things automatically in the future?

We could, but it's not necessary. Sometimes even the new major version doesn't change any option, it's not suitable for us to update (that's why my last CI change PR didn't update to v4s, all the options are the same, an internal change broke everything). I'd suggest that we stay to the manual update so we can just update when really needed.

@Cubik65536
Copy link
Member Author

P.S.: An update to 121.0.6167.139 is included now in the PR.

@Cubik65536
Copy link
Member Author

Cubik65536 commented Feb 3, 2024

I'll merge it.

@Cubik65536 Cubik65536 merged commit 755c1d9 into ungoogled-software:master Feb 3, 2024
1 check passed
@Cubik65536 Cubik65536 deleted the ci/new-tag-and-artifact-action branch February 3, 2024 14:56
@Cubik65536
Copy link
Member Author

@claudiodekker Do you have some knowledge on Homebrew Cask? Our brew cask code also has to be updated so Homebrew would work with the new tag format. Wondering if you can help me do that because I will be a little busy for the next few days and may not be able to do that quickly.

@claudiodekker
Copy link

@Cubik65536 Yeah, sure, where can I find the code for this?

@Cubik65536
Copy link
Member Author

@Cubik65536 Yeah, sure, where can I find the code for this?

You can find it here: https://github.com/Homebrew/homebrew-cask/blob/master/Casks/e/eloston-chromium.rb

@Cubik65536
Copy link
Member Author

You will need to change the livecheck section. Don't touch the version and sha256 info unless there's already a finished build here. /cc @claudiodekker

Thanks a lot! You saved my life 🤣

@Cubik65536
Copy link
Member Author

By the way, just a note here, according to this GitHub blog article, we can now use ARM machine to run our CI, and I do plan to migrate our arm building to this later (avoid the cross compiling will save a lot of time).

@claudiodekker
Copy link

claudiodekker commented Feb 3, 2024

@Cubik65536 Got an update ready (& verified against your "test" repository). As it turns out, the livecheck regex itself was already tolerant to timestamp-less version tags, so there was little work to do there.

I did however also take the opportunity to clean up some of the cask definition and fix a brew audit issue, so all that's left now is to wait for the build to finish, and submit the PR with the up-to-date hashes, but you can rely on me to do that tomorrow once the build finishes 👍

If you're interested in my changes though, here's the commit: claudiodekker/homebrew-cask@fabbbfc

@Cubik65536
Copy link
Member Author

@Cubik65536 Got an update ready (& verified against your "test" repository). As it turns out, the livecheck regex itself was already tolerant to timestamp-less version tags, so there was little work to do there.

I did however also take the opportunity to clean up some of the cask definition and fix a brew audit issue, so all that's left now is to wait for the build to finish, and submit the PR with the up-to-date hashes, but you can rely on me to do that tomorrow once the build finishes 👍

If you're interested in my changes though, here's the commit: claudiodekker/homebrew-cask@fabbbfc

Your changes look good! Thank you!

@claudiodekker
Copy link

claudiodekker commented Feb 4, 2024

@Cubik65536 Cask changes have been PR'd & merged: Homebrew/homebrew-cask#165983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A small suggestion for the Release Notes
3 participants