-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A small suggestion for the Release Notes #146
Comments
Yeah it is an unexpected problem to have it mismatched (I introduced this bug and haven't found it) and I do plan to remove these in the next update. My plan is to just remove entirely the epoch timestamp from the release (from tag, title, and body), and also just use the Any opinions on this? /cc @networkException @PF4Public |
yep, I'm definitely in favor of removing the timestamp. I'm not entirely sure if they were added because CI was unstable or frequent rebuilds were needed, though |
For now, we shouldn't need to rerun CIs unless we're changing the CI script and just want to test it. And I don't see any cases where there will be rebuilds (with the old script, it's possible that multiple releases will be created, it won't happen again). I will make this change in the next update then. |
Since the release title already includes the version and timestamp, it might be unnecessary to repeat this information in the release body, especially since the two timestamps do not match.
Simply delete these two lines.
ungoogled-chromium-macos/.github/scripts/github_generate_release_note.sh
Lines 17 to 18 in 4853bf0
The text was updated successfully, but these errors were encountered: