Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small suggestion for the Release Notes #146

Closed
577 opened this issue Jan 29, 2024 · 4 comments · Fixed by #147
Closed

A small suggestion for the Release Notes #146

577 opened this issue Jan 29, 2024 · 4 comments · Fixed by #147

Comments

@577
Copy link

577 commented Jan 29, 2024

Since the release title already includes the version and timestamp, it might be unnecessary to repeat this information in the release body, especially since the two timestamps do not match.

ScreenShot_20240128_hJkbuelfpBd4gihF

Simply delete these two lines.

printf '## Ungoogled-Chromium %s\n' "$_release_tag_version" | tee -a ./github_release_note.md
printf '\n' | tee -a ./github_release_note.md

@Cubik65536
Copy link
Member

Cubik65536 commented Jan 29, 2024

Yeah it is an unexpected problem to have it mismatched (I introduced this bug and haven't found it) and I do plan to remove these in the next update.

My plan is to just remove entirely the epoch timestamp from the release (from tag, title, and body), and also just use the chromium_version + ungoogled_revision (in this case, just the 121.0.6167.85-1.1) for both the tag and the release title, so that it behaves in the same way as the other repos in the org. (As mentioned here a bit (sort of))

Any opinions on this? /cc @networkException @PF4Public

@networkException
Copy link
Member

yep, I'm definitely in favor of removing the timestamp. I'm not entirely sure if they were added because CI was unstable or frequent rebuilds were needed, though

@Cubik65536
Copy link
Member

yep, I'm definitely in favor of removing the timestamp. I'm not entirely sure if they were added because CI was unstable or frequent rebuilds were needed, though

For now, we shouldn't need to rerun CIs unless we're changing the CI script and just want to test it. And I don't see any cases where there will be rebuilds (with the old script, it's possible that multiple releases will be created, it won't happen again).

I will make this change in the next update then.

@claudiodekker
Copy link

yep, I'm definitely in favor of removing the timestamp. I'm not entirely sure if they were added because CI was unstable or frequent rebuilds were needed, though

They were added in #92, perhaps @kramred has any recollection of it if they're around?

@Cubik65536 Cubik65536 linked a pull request Feb 2, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants