-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Allow a single CI run to build & release for both x86-64 and arm64 #142
ci: Allow a single CI run to build & release for both x86-64 and arm64 #142
Conversation
A related question @networkException , will we still have two individual releases (for two arch) or a single release that contains binaries for both x86-64 and arm64? |
Whatever is easier for you |
I'll try to put it in a single release then. We might also have to change something with our brew cask (not very familiar with that, will take a deeper look later). |
Signed-off-by: Qian Qian "Cubik" <[email protected]>
10186e5
to
e2c8cba
Compare
Signed-off-by: Qian Qian "Cubik" <[email protected]>
Signed-off-by: Qian Qian "Cubik" <[email protected]>
…arm64 Signed-off-by: Qian Qian "Cubik" <[email protected]>
Signed-off-by: Qian Qian "Cubik" <[email protected]>
This change is made so that x86-64 and arm64 builds can be executed at the same time, which saves significantly CI run times. Signed-off-by: Qian Qian "Cubik" <[email protected]>
Signed-off-by: Qian Qian "Cubik" <[email protected]>
Signed-off-by: Qian Qian "Cubik" <[email protected]>
Signed-off-by: Qian Qian "Cubik" <[email protected]>
Signed-off-by: Qian Qian "Cubik" <[email protected]>
Signed-off-by: Qian Qian "Cubik" <[email protected]>
Signed-off-by: Qian Qian "Cubik" <[email protected]>
Signed-off-by: Qian Qian "Cubik" <[email protected]>
Signed-off-by: Qian Qian "Cubik" <[email protected]>
Signed-off-by: Qian Qian "Cubik" <[email protected]>
Signed-off-by: Qian Qian "Cubik" <[email protected]>
Signed-off-by: Qian Qian "Cubik" <[email protected]>
Signed-off-by: Qian Qian "Cubik" <[email protected]>
Hi, I still receive the error:
An error occurred. (Error code: 9) (Extra code: 0)
Learn more <https://support.9oo91e.qjz9zk/chrome?p=update_error>
Version 120.0.6099.216 (Official Build, ungoogled-chromium) (arm64)
On 14 Jan 2024, at 20:51, Cubik65536 ***@***.***> wrote:
Testing here (just a manual trigger, w/o a release) <https://github.com/iXORTech/ungoogled-chromium-macos/actions/runs/7523608741> and here (push to a tag, w/ a release) <https://github.com/iXORTech/ungoogled-chromium-macos/actions/runs/7523617042>.
—
Reply to this email directly, view it on GitHub <#142 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AWR5O3EVHNDQFZ53KF3YMCLYOSKRNAVCNFSM6AAAAABBZSJ4M2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJRGIZDENZSGE>.
You are receiving this because you are subscribed to this thread.
|
First, this is probably the least place you should report this issue. |
I’m really sorry. My bad. Thanks.
On 15 Jan 2024, at 11:42, Cubik65536 ***@***.***> wrote:
Hi, I still receive the error: An error occurred. (Error code: 9) (Extra code: 0) Learn more <support.9oo91e.qjz9zk/chrome?p=update_error <https://support.9oo91e.qjz9zk/chrome?p=update_error>> Version 120.0.6099.216 (Official Build, ungoogled-chromium) (arm64) On 14 Jan 2024, at 20:51, Cubik65536 @.***> wrote: Testing here (just a manual trigger, w/o a release) <iXORTech/ungoogled-chromium-macos/actions/runs/7523608741 <https://github.com/iXORTech/ungoogled-chromium-macos/actions/runs/7523608741>> and here (push to a tag, w/ a release) <iXORTech/ungoogled-chromium-macos/actions/runs/7523617042 <https://github.com/iXORTech/ungoogled-chromium-macos/actions/runs/7523617042>>. — Reply to this email directly, view it on GitHub <#142 (comment) <#142 (comment)>>, or unsubscribe <github.com/notifications/unsubscribe-auth/AWR5O3EVHNDQFZ53KF3YMCLYOSKRNAVCNFSM6AAAAABBZSJ4M2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJRGIZDENZSGE <https://github.com/notifications/unsubscribe-auth/AWR5O3EVHNDQFZ53KF3YMCLYOSKRNAVCNFSM6AAAAABBZSJ4M2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJRGIZDENZSGE>>. You are receiving this because you are subscribed to this thread.
First, this is probably the least place you should report this issue.
Second, check description of #134 <#134>.
—
Reply to this email directly, view it on GitHub <#142 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AWR5O3C2UNQ2ZBOJE5UUUKLYOVTBZAVCNFSM6AAAAABBZSJ4M2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJSGU3TGNZXGI>.
You are receiving this because you commented.
|
Signed-off-by: Qian Qian "Cubik" <[email protected]>
The test without release worked. |
Did it work in the end? There is an error:
|
No it didn’t, will have a fix. |
Signed-off-by: Qian Qian "Cubik" <[email protected]>
The action w/ release worked (finally!) and here's the corresponding test release. Now ready for review. |
I think I will skip 120.0.6099.224 and directly update to 121.0.6167.75 after this PR have been merged and when 121.0.6167.75 gets released. |
@networkException any objections to merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no
Thanks @Cubik65536 |
Yeah, you're absolutely right, and my apologies for my initial wording on that comment. I didn't intend to come across as biased for or against the change either way. It was just something that stood out to me as an unexpected change when I was preparing my automated signing builds to be compatible with this change, and something that might've easily slipped through with others as well. As for the version-number only argument: This is also my experience, as generally projects consider it kind of a given that you're aware as to what project you're looking at / are browsing in anyway, but I'll leave it up to the maintainers to make those kinds of decisions :) |
This PR changes the ci process and allows one GitHub Action run to build both x86-64 and arm64 builds for ungoogled-chromium macOS.
It also uses the
actions/setup-python
action to setup Python 3.11 environment. This is an attempt to permanently "fix" thebs4.FeatureNotFound: Couldn't find a tree builder with the features you requested: html5lib. Do you need to install a parser library?
issue when building with GitHub CI and when Python 3.12 (and above, prehaps?) is used.TODO List: