Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to ungoogled-chromium 120.0.6099.71 #134

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Update to ungoogled-chromium 120.0.6099.71 #134

merged 7 commits into from
Dec 12, 2023

Conversation

Cubik65536
Copy link
Member

@Cubik65536 Cubik65536 commented Dec 9, 2023 •
edited
Loading

Notes:

  • A submodule bump is made.
  • A patch refresh is made.
  • The flag changes in [4903785] were reverted.
  • Add a nodejs download.
  • Upgrade the LLVM toolchain to 17.0.6
  • Suppress unknown warnings (borrowed from ungoogled-chromium-windows 🧐)

Builds and runs fine locally.

image

Note

The error is caused by the Chromium update feature that have been blocked. (more on that at #145)

@Cubik65536
Update to ungoogled-chromium 120.0.6099.71
5ee7332 
Signed-off-by: Qian Qian "Cubik"‎ <[email protected]>
@Cubik65536
Update patches
9dd6ec1 
Signed-off-by: Qian Qian "Cubik"‎ <[email protected]>
@Cubik65536
Remove missing clang flags
dd01f8d 
Revert flag changes in https://chromium-review.googlesource.com/c/chromium/src/+/4903785

Signed-off-by: Qian Qian "Cubik"‎ <[email protected]>
@Cubik65536
build: Add download for nodejs
63ab42a 
Signed-off-by: Qian Qian "Cubik"‎ <[email protected]>
@Cubik65536 Cubik65536 marked this pull request as ready for review December 10, 2023 00:28
@Cubik65536
Upgrade the LLVM toolchain to 17.0.6
2b6431e
@Cubik65536
Readd disable clang version check patch
2c87c88 
This was removed by accident from an earlier update.
[skip ci]

Signed-off-by: Qian Qian "Cubik"‎ <[email protected]>
@Cubik65536
Disable clang unknown warnings
b5e829f 
Signed-off-by: Qian Qian "Cubik"‎ <[email protected]>
@Cubik65536
Copy link
Member Author

/cc @networkException @PF4Public

@networkException networkException merged commit 2a1ac3f into ungoogled-software:master Dec 12, 2023
10 checks passed
@PF4Public
Copy link
Contributor

PF4Public commented Dec 14, 2023 •
edited
Loading

@networkException Were binaries created for this one or did it fail again?

@networkException
Copy link
Member

hm looks like GitHub just didn't start this one..

@Cubik65536
Copy link
Member Author

Cubik65536 commented Dec 15, 2023 •
edited
Loading

hm looks like GitHub just didn't start this one..

ummm

Yeah, one of my commit message have a [skip ci] tag that got into the merge commit's message body... It seems that it can be placed anywhere and GitHub will skip the CI process. I will try to avoid using that in the future then.

@networkException
Copy link
Member

oh I see, haha 😅

@Cubik65536 Cubik65536 deleted the 120.0.6099.71 branch December 15, 2023 00:33
@Cubik65536 Cubik65536 mentioned this pull request Jan 15, 2024
Merged
4 tasks
@Cubik65536 Cubik65536 mentioned this pull request Jan 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@networkException networkException networkException approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cubik65536 @PF4Public @networkException