Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: DBTP-1700 Deprecate cross_enviroment_service_access application property #345

Conversation

WillGibson
Copy link
Contributor

@WillGibson WillGibson commented Feb 20, 2025

Found while working on DBTP-1700.

It is a required field, but not used for anything 😬

Just made it optional for now and will document it as deprecated in https://github.com/uktrade/platform-documentation/pull/498.

Goes with uktrade/platform-tools#780 and https://github.com/uktrade/demodjango-deploy/pull/286.


Checklist:

Title:

  • Scope included as per conventional commits
  • Ticket reference included (unless it's a quick out of ticket thing)

Description:

  • Link to ticket included (unless it's a quick out of ticket thing)
  • Includes tests (or an explanation for why it doesn't)
  • Includes any applicable changes to the documentation in this code base
  • Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

End to end test run.

@WillGibson WillGibson changed the title DBTP-1700 Deprecate cross_enviroment_service_access application property chore: DBTP-1700 Deprecate cross_enviroment_service_access application property Feb 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.68%. Comparing base (e1c9d77) to head (0b78dee).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   81.68%   81.68%           
=======================================
  Files           7        7           
  Lines         868      868           
=======================================
  Hits          709      709           
  Misses        159      159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WillGibson WillGibson marked this pull request as ready for review February 20, 2025 14:22
@WillGibson WillGibson requested a review from a team as a code owner February 20, 2025 14:22
@WillGibson WillGibson merged commit f3ca44c into main Feb 20, 2025
50 checks passed
@WillGibson WillGibson deleted the DBTP-1700-deprecate-cross_environment-service-access-application branch February 20, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants