chore: DBTP-1700 Deprecate cross_enviroment_service_access application property #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillGibson
commented
Feb 20, 2025
| "application": str, | ||
| # Deprecated: We didn't implement cross application access, no service teams are asking for it. | ||
| # application should be removed once we can confirm that no-one is using it. | ||
| Optional("application"): str, |
There was a problem hiding this comment.
As discussed with @antroy-madetech and @ksugden.
chiaramapellimt
approved these changes
Feb 20, 2025
7 tasks
…e-access-application
…e-access-application
WillGibson
deleted the
DBTP-1700-deprecate-cross_environment-service-access-application
branch
WillGibson
added a commit
that referenced
this pull request
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while working on DBTP-1700.
It is a required field, but not used for anything 😬
Just made it optional for now and will document it as deprecated in https://github.com/uktrade/platform-documentation/pull/498.
Goes with uktrade/terraform-platform-modules#345 and https://github.com/uktrade/demodjango-deploy/pull/286.
Checklist:
Title:
Description:
If the work includes user interface changes, before and after screenshots included in descriptionIncludes any applicable changes to the documentation in this code baseTasks:
End to end test run.