Feature/cls2 695 allow for deletion of tasks #6549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #51357 ↗︎
Details:
Review all test suite changes for PR #6549 ↗︎ |
|||||||||||||||
dredmonds
approved these changes
Feb 23, 2024
| submitButtonLabel="Delete task" | ||
| initialValues={task} | ||
| > | ||
| {() => <></>} |
There was a problem hiding this comment.
I think more elegant to remove empty arrow function inside Form component to make it like this:
<Form
id="task-delete-form"
data-test="task-delete-form"
...<more props>
/>
marijnkampf
force-pushed
the
feature/task-deletion
branch
from
99e698b to
47dd438
Compare
marijnkampf
force-pushed
the
feature/CLS2-695-allow-for-deletion-of-tasks
branch
from
0988a40 to
d833496
Compare
marijnkampf
added a commit
that referenced
this pull request
Feb 27, 2024
* Update the FE to use the new status field and allow for Deletion of Tasks using archived.
marijnkampf
added a commit
that referenced
this pull request
Feb 28, 2024
* Update the FE to use the new status field and allow for Deletion of Tasks using archived.
marijnkampf
added a commit
that referenced
this pull request
Feb 28, 2024
* Use status complete/active instead of archive true/false (#6497 / #6543) * Feature/cls2 695 allow for deletion of tasks (#6549) --------- Co-authored-by: Claudia Gonzalez-Casales @ClaudiaGC1339 Co-authored-by: santosh dasari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Update the FE to use the new status field and allow for Deletion of Tasks using archived.
On the my tasks dashboard deleted tasks should be hidden.
On the task details page, show DELETED status on the task - this is so users can click through from ‘task deleted by other user’ notification.
Add Delete button on Task view page using.
Test instructions
Screenshots
Before
No delete button visible.
After
A delete button should be displayed on the Edit Task page.
Checklist