Feature/task deletion #6557
Merged
Feature/task deletion #6557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #51421 ↗︎
Details:
Review all test suite changes for PR #6557 ↗︎ |
|||||||||||||||
marijnkampf
force-pushed
the
feature/task-deletion
branch
from
acde6cb to
7da59f5
Compare
oliverjwroberts
requested changes
Feb 27, 2024
swenban
approved these changes
Feb 27, 2024
* Use status complete/active instead of archive true/false --------- Co-authored-by: Marijn Kampf <[email protected]>
* Use status for active and complete * Add API calls to a11y test exclusion list * Fix tasks/details-spec.js
* Update the FE to use the new status field and allow for Deletion of Tasks using archived.
Fix test description
marijnkampf
force-pushed
the
feature/task-deletion
branch
from
535e165 to
4dd9ce4
Compare
oliverjwroberts
approved these changes
Feb 28, 2024
chopkinsmade
pushed a commit
that referenced
this pull request
Feb 28, 2024
generated from commit 194a5de
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Combination of previously reviewed sub tickets into feature branch.
Replace completing of tickets using archived with status is complete.
Add delete functionality using archived.
Description of change
Update the FE to use the new status field and allow for Deletion of Tasks using archived.
On the my tasks dashboard deleted tasks should be hidden.
On the task details page, show DELETED status on the task - this is so users can click through from ‘task deleted by other user’ notification.
Add Delete button on Task view page using.
Test instructions
Run this locally with the feature/task-deletion branch on the API.
Screenshots
Before
No delete button visible.
After
A delete button should be displayed on the Edit Task page.
Dashboard
No visual changes in the my tasks dashboard
Checklist