[108, 87] Close Mentorship (endpoint, button handle, email notifications) #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tupu-app ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
ready to be reviewed |
raluka
approved these changes
Feb 17, 2023
maranta1
reviewed
Feb 19, 2023
| const { isOpen: isAlertDialogOpen, onOpen: onAlertDialogOpen, onClose: onAlertDialogClose } = useDisclosure(); | ||
| const cancelRef = useRef(); | ||
| const toast = useToast(); | ||
|
|
There was a problem hiding this comment.
Should we move the mutateRelationshipsList and changeMentorshipRelationship functions into a separate file? At the moment they will be declared again each time the component renders
There was a problem hiding this comment.
I created a follow up ticket: #118
Co-authored-by: Raluca Badoi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Github issue does this PR relate to?
Close #108
Close #87
Changes proposed in this pull request:
What should the reviewer know?
the handle for the button to close the mentorship is temporary, and it should be moved into #107
Quality Assurance(QA) Checklist