Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify MentorshipsList and MenteesList into MentorshipsList #118

Open
lorepirri opened this issue Feb 21, 2023 · 0 comments
Open

Unify MentorshipsList and MenteesList into MentorshipsList #118

lorepirri opened this issue Feb 21, 2023 · 0 comments
Labels

Comments

@lorepirri
Copy link
Contributor

Problem

PR #116 and PR #112 created code duplication

these two are basically the same:

components/MentorshipsList/MentorshipCard.js
components/MentorshipsList/index.js

and

components/MenteesList/MenteeCard.js
components/MenteesList/index.js

Feature Description

just unify them into one

components/MentorshipsList/MentorshipCard.js
components/MentorshipsList/index.js

and render Mentee or Mentor info according to which mode the user is into (mentor or mentee)

the endpoint already support the param mode to be mentee or mentor (see pages/api/mentorships.js).

also address this comment: #112 (comment) from @maranta1

Describe the feature/solution you'd like. A clear and concise description of what you want to happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant