Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133814 / 25.10 / More strict null fixes #11400

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+241 −187

Merge branch 'master' of github.com:truenas/webui into NAS-133814

a474959
Select commit
Loading
Failed to load commit list.
Open

NAS-133814 / 25.10 / More strict null fixes #11400

Merge branch 'master' of github.com:truenas/webui into NAS-133814
a474959
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 28, 2025 in 0s

82.93% (-0.01%) compared to a766a09

View this Pull Request on Codecov

82.93% (-0.01%) compared to a766a09

Details

Codecov Report

Attention: Patch coverage is 78.94737% with 28 lines in your changes missing coverage. Please review.

Project coverage is 82.93%. Comparing base (a766a09) to head (a474959).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ruenas-connect/services/truenas-connect.service.ts 0.00% 3 Missing ⚠️
...disk-details-panel/disk-details-panel.component.ts 0.00% 3 Missing ⚠️
...s/ix-forms/components/ix-list/ix-list.component.ts 0.00% 2 Missing ⚠️
...tives/tree-virtual-scroll-node-outlet.directive.ts 0.00% 2 Missing ⚠️
...eneral-settings/gui/gui-form/gui-form.component.ts 0.00% 2 Missing ⚠️
...ate-and-interact/navigate-and-highlight.service.ts 66.66% 1 Missing ⚠️
...entials-select/ssh-credentials-select.component.ts 0.00% 1 Missing ⚠️
...-dataset-dialog/create-dataset-dialog.component.ts 75.00% 1 Missing ⚠️
...s/ix-select/ix-select-with-new-option.directive.ts 50.00% 1 Missing ⚠️
...s/forms/ix-forms/services/ix-validators.service.ts 75.00% 1 Missing ⚠️
... and 11 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #11400      +/-   ##
==========================================
- Coverage   82.94%   82.93%   -0.01%     
==========================================
  Files        1672     1672              
  Lines       59959    59998      +39     
  Branches     6308     6356      +48     
==========================================
+ Hits        49733    49762      +29     
- Misses      10226    10236      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov