Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133814 / 25.10 / More strict null fixes #11400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Jan 27, 2025

Testing:

General regression testing and code review.

@undsoft undsoft requested a review from a team as a code owner January 27, 2025 00:51
@undsoft undsoft requested review from RehanY147 and removed request for a team January 27, 2025 00:51
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-133814: More strict null fixes NAS-133814 / 25.10 / More strict null fixes Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 78.35821% with 29 lines in your changes missing coverage. Please review.

Project coverage is 82.93%. Comparing base (7ac1d77) to head (c253f72).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ruenas-connect/services/truenas-connect.service.ts 0.00% 3 Missing ⚠️
...disk-details-panel/disk-details-panel.component.ts 0.00% 3 Missing ⚠️
...s/ix-forms/components/ix-list/ix-list.component.ts 0.00% 2 Missing ⚠️
...tives/tree-virtual-scroll-node-outlet.directive.ts 0.00% 2 Missing ⚠️
...eneral-settings/gui/gui-form/gui-form.component.ts 0.00% 2 Missing ⚠️
...ate-and-interact/navigate-and-highlight.service.ts 66.66% 1 Missing ⚠️
src/app/directives/ui-search.directive.ts 0.00% 1 Missing ⚠️
...entials-select/ssh-credentials-select.component.ts 0.00% 1 Missing ⚠️
...-dataset-dialog/create-dataset-dialog.component.ts 75.00% 1 Missing ⚠️
...s/ix-select/ix-select-with-new-option.directive.ts 50.00% 1 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11400      +/-   ##
==========================================
- Coverage   82.94%   82.93%   -0.01%     
==========================================
  Files        1669     1669              
  Lines       59916    59955      +39     
  Branches     6298     6346      +48     
==========================================
+ Hits        49695    49724      +29     
- Misses      10221    10231      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants