Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-133783 / 25.10 / Root disk size setting #11387

Merged
merged 2 commits into from
Jan 27, 2025
Merged

NAS-133783 / 25.10 / Root disk size setting #11387

merged 2 commits into from
Jan 27, 2025
+188 −118

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Jan 25, 2025

Changes:

Adds root disk size field for VMs.

@undsoft undsoft added the backport-25.04-RC.1 Fangtooth RC1 label Jan 25, 2025
@undsoft undsoft requested a review from a team as a code owner January 25, 2025 03:05
@undsoft undsoft requested review from bvasilenko and removed request for a team January 25, 2025 03:05
@bugclerk
Copy link
Contributor

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133783

@bugclerk bugclerk changed the title NAS-133783: Root disk size setting NAS-133783 / 25.10 / Root disk size setting Jan 25, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.94%. Comparing base (7ac1d77) to head (ba83390).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #11387   +/-   ##
=======================================
  Coverage   82.94%   82.94%           
=======================================
  Files        1669     1669           
  Lines       59916    59919    +3     
  Branches     6298     6299    +1     
=======================================
+ Hits        49695    49701    +6     
+ Misses      10221    10218    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft added the backport-25.04-BETA.1 Fangtooth Beta label Jan 25, 2025
denysbutenko
denysbutenko approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looks good.

@undsoft undsoft merged commit 217a59f into master Jan 27, 2025
11 checks passed
@undsoft undsoft deleted the NAS-133783 branch January 27, 2025 12:52
This was referenced Jan 27, 2025
Merged
Merged
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@denysbutenko denysbutenko denysbutenko approved these changes

@bvasilenko bvasilenko Awaiting requested review from bvasilenko bvasilenko is a code owner automatically assigned from truenas/ui-team

@AlexKarpov98 AlexKarpov98 Awaiting requested review from AlexKarpov98

Assignees
No one assigned
Labels
backport-25.04-BETA.1 Fangtooth Beta backport-25.04-RC.1 Fangtooth RC1 backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@undsoft @bugclerk @denysbutenko