Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133783 / 25.04-RC.1 / Root disk size setting (by undsoft) #11407

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

bugclerk
Copy link
Contributor

Changes:

Adds root disk size field for VMs.

Original PR: #11387
Jira URL: https://ixsystems.atlassian.net/browse/NAS-133783

(cherry picked from commit ba51c65)
@bugclerk bugclerk requested a review from a team as a code owner January 27, 2025 12:52
@bugclerk bugclerk requested review from AlexKarpov98 and removed request for a team January 27, 2025 12:52
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable/fangtooth@2772167). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             stable/fangtooth   #11407   +/-   ##
===================================================
  Coverage                    ?   82.94%           
===================================================
  Files                       ?     1669           
  Lines                       ?    59915           
  Branches                    ?     6295           
===================================================
  Hits                        ?    49698           
  Misses                      ?    10217           
  Partials                    ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit aa78c23 into stable/fangtooth Jan 27, 2025
11 checks passed
@undsoft undsoft deleted the NAS-133783-25.04-RC.1 branch January 27, 2025 13:26
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants