Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add default value for argument 'TRITON_REPO_ORGANIZATION' from sdk Dockerfile #7437

Merged
merged 3 commits into from
Aug 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Dockerfile.sdk
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ ARG BASE_IMAGE=nvcr.io/nvidia/tritonserver:24.07-py3-min

ARG TRITON_CLIENT_REPO_SUBDIR=clientrepo
ARG TRITON_PA_REPO_SUBDIR=perfanalyzerrepo
ARG TRITON_REPO_ORGANIZATION=http://github.com/triton-inference-server
ARG TRITON_COMMON_REPO_TAG=main
ARG TRITON_CORE_REPO_TAG=main
ARG TRITON_CLIENT_REPO_TAG=main
Expand Down
12 changes: 6 additions & 6 deletions docs/customization_guide/build.md
Original file line number Diff line number Diff line change
Expand Up @@ -331,13 +331,13 @@ invocation builds all features and backends available on windows.
python build.py --cmake-dir=<path/to/repo>/build --build-dir=/tmp/citritonbuild --no-container-pull --image=base,win10-py3-min --enable-logging --enable-stats --enable-tracing --enable-gpu --endpoint=grpc --endpoint=http --repo-tag=common:<container tag> --repo-tag=core:<container tag> --repo-tag=backend:<container tag> --repo-tag=thirdparty:<container tag> --backend=ensemble --backend=tensorrt:<container tag> --backend=onnxruntime:<container tag> --backend=openvino:<container tag>
```

If you are building on *main* branch then '<container tag>' will
If you are building on *main* branch then `<container tag>` will
default to "main". If you are building on a release branch then
'<container tag>' will default to the branch name. For example, if you
are building on the r24.07 branch, '<container tag>' will default to
r24.07. Therefore, you typically do not need to provide '<container
tag>' at all (nor the preceding colon). You can use a different
'<container tag>' for a component to instead use the corresponding
`<container tag>` will default to the branch name. For example, if you
are building on the r24.07 branch, `<container tag>` will default to
r24.07. Therefore, you typically do not need to provide `<container
tag>` at all (nor the preceding colon). You can use a different
`<container tag>` for a component to instead use the corresponding
branch/tag in the build. For example, if you have a branch called
"mybranch" in the
[onnxruntime_backend](https://github.com/triton-inference-server/onnxruntime_backend)
Expand Down
13 changes: 8 additions & 5 deletions docs/customization_guide/test.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ $ ./gen_qa_model_repository
$ ./gen_qa_custom_ops
```

This will create multiple model repositories in /tmp/<version>/qa_*
This will create multiple model repositories in /tmp/\<version\>/qa_*
(for example /tmp/24.07/qa_model_repository). The TensorRT models
will be created for the GPU on the system that CUDA considers device 0
(zero). If you have multiple GPUs on your system see the documentation
Expand All @@ -57,14 +57,17 @@ in the scripts for how to target a specific GPU.
## Build SDK Image

Build the *tritonserver_sdk* image that contains the client
libraries, model analyzer, and examples using the following
commands. You must first checkout the <client branch> branch of the
*client* repo into the clientrepo/ subdirectory. Typically you want to
set <client branch> to be the same as your current server branch.
libraries, model analyzer, perf analyzer and examples using the following
commands. You must first checkout the `<client branch>` branch of the
*client* repo into the clientrepo/ subdirectory and the `<perf analyzer branch>`
branch of the *perf_analyzer* repo into the perfanalyzerrepo/ subdirectory
respectively. Typically you want to set both `<client branch>` and `<perf analyzer branch>`
to be the same as your current server branch.

```
$ cd <server repo root>
$ git clone --single-branch --depth=1 -b <client branch> https://github.com/triton-inference-server/client.git clientrepo
$ git clone --single-branch --depth=1 -b <perf analyzer branch> https://github.com/triton-inference-server/perf_analyzer.git perfanalyzerrepo
$ docker build -t tritonserver_sdk -f Dockerfile.sdk .
```

Expand Down
Loading