Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add default value for argument 'TRITON_REPO_ORGANIZATION' from sdk Dockerfile #7437

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

zhanga5
Copy link
Contributor

@zhanga5 zhanga5 commented Jul 11, 2024

What does the PR do?

Add default value for argument TRITON_REPO_ORGANIZATION from sdk Dockerfile. Otherwise it breaks manual build described from https://github.com/triton-inference-server/server/blob/main/docs/customization_guide/test.md#build-sdk-image. This issue seems introduced by PR #6934

And add instruction about clone perf analyzer repo for SDK image build. It's new added to sdk Dockerfile by #7449. And escape angle brackets surrounded strings properly.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build

Related PRs:

n/a

Where should the reviewer start?

n/a

Test plan:

Manual build sdk docker image that's described from https://github.com/triton-inference-server/server/blob/main/docs/customization_guide/test.md#build-sdk-image

  • CI Pipeline ID:
    n/a

Caveats:

n/a

Background

n/a

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

n/a

@zhanga5 zhanga5 added the PR: build Changes that affect the build system or external dependencies label Jul 11, 2024
@zhanga5 zhanga5 force-pushed the zhanga5-fix-sdk-dockerfile branch from 914e702 to ded1c20 Compare July 12, 2024 02:14
@zhanga5 zhanga5 force-pushed the zhanga5-fix-sdk-dockerfile branch from 2fc47c8 to 1fb73d0 Compare August 1, 2024 03:07
Copy link
Contributor

@fpetrini15 fpetrini15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhanga5 zhanga5 merged commit cca12f9 into main Aug 5, 2024
3 checks passed
@zhanga5 zhanga5 deleted the zhanga5-fix-sdk-dockerfile branch August 5, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: build Changes that affect the build system or external dependencies
Development

Successfully merging this pull request may close these issues.

2 participants