Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Slow Zone map effective date #1032

Merged
merged 1 commit into from
Feb 6, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions modules/slowzones/map/segment.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { Diagram, SegmentLocation } from '@transitmatters/stripmap';

import dayjs from 'dayjs';
import type {
SlowZoneAllSlowResponse,
SlowZoneResponse,
Expand Down Expand Up @@ -44,11 +45,11 @@ type WithSegmentLocation<T> = {
* Get the latest date that we have data on slow zones for
*/
const getEffectiveDate = (desiredDate: Date, slowZones: SlowZoneAllSlowResponse) => {
const maxEndDate = new Date(slowZones.updated_on);
if (desiredDate.valueOf() > maxEndDate.valueOf()) {
const maxEndDate = dayjs(new Date(slowZones.updated_on)).startOf('day').toDate();
if (dayjs(desiredDate).isAfter(maxEndDate)) {
return maxEndDate;
}
return desiredDate;
return dayjs(desiredDate).startOf('day').toDate();
};

const filterActiveElements = <T extends Record<string, unknown>>(
Expand Down
Loading