Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Slow Zone map effective date #1032

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Fix Slow Zone map effective date #1032

merged 1 commit into from
Feb 6, 2025

Conversation

devinmatte
Copy link
Member

Motivation

We fixed the map when it was 0s of slow zones, but now it only works on day 2 of the slow zone. This fixes that

Changes

  • Checks dates and sets them to the start of day
  • That way we're comparing apples to apples

Testing Instructions

@github-actions github-actions bot added the frontend Change to frontend code label Feb 6, 2025
idreyn
idreyn approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@idreyn idreyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classic!

@devinmatte devinmatte merged commit 7f6eda4 into main Feb 6, 2025
5 checks passed
@devinmatte devinmatte deleted the fix-slowzone-map branch February 6, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idreyn idreyn idreyn approved these changes

@mathcolo mathcolo Awaiting requested review from mathcolo mathcolo is a code owner

@skaplan-dev skaplan-dev Awaiting requested review from skaplan-dev skaplan-dev is a code owner

@PatrickCleary PatrickCleary Awaiting requested review from PatrickCleary PatrickCleary is a code owner

Assignees
No one assigned
Labels
frontend Change to frontend code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinmatte @idreyn