use expect_null where appropriate #6211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelChirico
added a commit
to MichaelChirico/dplyr
that referenced
this pull request
Mar 22, 2022
Similar to tidyverse#6211 -- caught with `lintr::expect_type_linter()`.
|
Thanks @MichaelChirico! |
DavisVaughan
pushed a commit
to MichaelChirico/dplyr
that referenced
this pull request
May 24, 2022
Similar to tidyverse#6211 -- caught with `lintr::expect_type_linter()`.
DavisVaughan
pushed a commit
that referenced
this pull request
May 24, 2022
* Use expect_type where appropriate Similar to #6211 -- caught with `lintr::expect_type_linter()`. * one more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surfaced by the new
lintr::expect_null_linter().Filing wondering:
testthatconsistency linters slated to be added tolintrtodplyr, seeExpect*linters in Upstreaming linters from Google's internal linting suite r-lib/lintr#884And also looking for feedback on how appropriate the lint is for usages in CRAN packages. Thanks.