Use expect_type() where appropriate in tests (#6217)

* Use expect_type where appropriate Similar to #6211 -- caught with `lintr::expect_type_linter()`. * one more
tidyverse · May 24, 2022 · 33f16b9 · 33f16b9
1 parent 778ec9b
commit 33f16b9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/tests/testthat/test-bind.R b/tests/testthat/test-bind.R
@@ -185,16 +185,16 @@ test_that("bind_rows() promotes integer to numeric", {
   df2 <- tibble(a = 1, b = 1L)
 
   res <- bind_rows(df1, df2)
-  expect_equal(typeof(res$a), "double")
-  expect_equal(typeof(res$b), "integer")
+  expect_type(res$a, "double")
+  expect_type(res$b, "integer")
 })
 
 test_that("bind_rows() promotes factor to character with warning", {
   df1 <- tibble(a = factor("a"))
   df2 <- tibble(a = "b")
 
   res <- bind_rows(df1, df2)
-  expect_equal(typeof(res$a), "character")
+  expect_type(res$a, "character")
 })
 
 test_that("bind_rows() coerces factor when levels don't match", {

diff --git a/tests/testthat/test-deprec-funs.R b/tests/testthat/test-deprec-funs.R
@@ -83,7 +83,7 @@ test_that("can enfun() purrr-style lambdas", {
   my_mean <- as_function(~ mean(.x))
   res <- enfun(~ mean(.x))
   expect_equal(length(res), 1L)
-  expect_true(typeof(res[[1]]) == "closure")
+  expect_type(res[[1]], "closure")
 })
 
 test_that("funs_ works", {