Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support ESLint flat config #902

Closed
wants to merge 6 commits into from
Closed

feat: support ESLint flat config #902

wants to merge 6 commits into from

Conversation

Belco90
Copy link
Member

@Belco90 Belco90 commented Apr 27, 2024

@Belco90 Belco90 added BREAKING CHANGE This change will require a major version bump v7 Next major v7 labels Apr 27, 2024
@Belco90 Belco90 self-assigned this Apr 27, 2024
MichaelDeBoey
MichaelDeBoey reviewed May 2, 2024
View reviewed changes
Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen multiple ESLint plugins that support both flat config & .eslintrc files, which could be a great upgrade path for people who can't use ESLint v9 (yet)

@Belco90
Copy link
Member Author

Belco90 commented May 2, 2024

@MichaelDeBoey Yes, planning to add compatibility with RC config finally, but will be a breaking change anyway (the configs will have a -legacy suffix as suggested in ESLint flat config migration guide).

@Belco90 Belco90 marked this pull request as draft May 2, 2024 20:51
@pplancq pplancq mentioned this pull request May 6, 2024
Closed
16 tasks
@wakamsha wakamsha mentioned this pull request May 20, 2024
Closed
@smittysmee
Copy link

Where are we at with this guy? I am itching to use it!

@michaelfaith
Copy link

michaelfaith commented Jun 20, 2024 •
edited
Loading

@Belco90 If you need any additional help with this, i'd be happy to pitch in.

This was referenced Aug 4, 2024
Closed
Merged
@Belco90 Belco90 closed this in #923 Aug 11, 2024
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 6.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey left review comments

Assignees

@Belco90 Belco90

Labels
BREAKING CHANGE This change will require a major version bump released v7 Next major v7
Projects
eslint-plugin-testing-library v7
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Belco90 @smittysmee @michaelfaith @MichaelDeBoey