Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add plugin name and version metadata for ESLint v9 #921

Closed
wants to merge 3 commits into from

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Aug 4, 2024

Checks

Changes

  • Add plugin name and version metadata

Context

Relates to #902 - this metadata is technically not required but preferred for ESLint v9 to be able to work.. better? (iirc its used for cache busting).

I've not added any tests for now as I think it's a small enough change that we can verify it's fine with our eyes :)

Copy link

codecov bot commented Aug 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (93a6ab9) to head (3b766d1).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #921      +/-   ##
==========================================
+ Coverage   96.23%   96.32%   +0.08%     
==========================================
  Files          44       44              
  Lines        2419     2446      +27     
  Branches     1000     1019      +19     
==========================================
+ Hits         2328     2356      +28     
+ Misses         91       90       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@G-Rath G-Rath mentioned this pull request Aug 4, 2024
1 task
Belco90
Belco90 previously approved these changes Aug 7, 2024
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this for the current version ❤️

@Belco90
Copy link
Member

Belco90 commented Aug 7, 2024

There are some types failing tho, can you take a look at that @G-Rath?

@G-Rath

This comment was marked as resolved.

@G-Rath
Copy link
Contributor Author

G-Rath commented Aug 7, 2024

ah right ok the issue is that now that we're importing from package.json, that gets copied by tsc as part of the build, and the package structure changes - tbh it might be easiest to just switch to using babel for compiling 🤔

@G-Rath G-Rath requested a review from Belco90 August 7, 2024 19:32
@Belco90
Copy link
Member

Belco90 commented Aug 7, 2024

That's what I was dealing with in the next major (introducing tsup), but don't have time right now to finish it.

@G-Rath
Copy link
Contributor Author

G-Rath commented Aug 7, 2024

Right, well in the meantime we can use plain require so now this should be good to land

@G-Rath
Copy link
Contributor Author

G-Rath commented Aug 7, 2024

@Belco90 fwiw #923 is also now passing and includes this change, so might be better to just land that one - I'll leave both open though in case you want to stagger them for dedicated changelog entries :)

@Belco90
Copy link
Member

Belco90 commented Aug 11, 2024

Closing in favor of #923

@Belco90 Belco90 closed this Aug 11, 2024
@G-Rath G-Rath deleted the add-metadata branch August 20, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants