-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add plugin name and version metadata for ESLint v9 #921
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #921 +/- ##
==========================================
+ Coverage 96.23% 96.32% +0.08%
==========================================
Files 44 44
Lines 2419 2446 +27
Branches 1000 1019 +19
==========================================
+ Hits 2328 2356 +28
+ Misses 91 90 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this for the current version ❤️
There are some types failing tho, can you take a look at that @G-Rath? |
This comment was marked as resolved.
This comment was marked as resolved.
ah right ok the issue is that now that we're importing from |
That's what I was dealing with in the next major (introducing tsup), but don't have time right now to finish it. |
Right, well in the meantime we can use plain |
Closing in favor of #923 |
Checks
Changes
Context
Relates to #902 - this metadata is technically not required but preferred for ESLint v9 to be able to work.. better? (iirc its used for cache busting).
I've not added any tests for now as I think it's a small enough change that we can verify it's fine with our eyes :)