document transmit_decoded_records configuration option #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agbpatro
reviewed
Jan 16, 2025
README.md
Outdated
| @@ -56,6 +56,7 @@ For ease of installation and operation, run Fleet Telemetry on Kubernetes or a s | |||
| "json_log_enable": bool, | |||
| "namespace": string - kafka topic prefix, | |||
| "reliable_ack": bool - for use with reliable datastores, recommend setting to true with kafka, | |||
| "transmit_decoded_records": bool - if true, transmit JSON to dispatchers instead of proto. false is recommended as using protos improves codebase maintainability. | |||
There was a problem hiding this comment.
nit: recommend removing false is recommended as using protos improves codebase maintainability
agbpatro
approved these changes
Jan 16, 2025
patrickdemers6
force-pushed
the
document-transmit-decoded-records
branch
from
32712fa to
b214980
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improving documentation of transmit_decoded_records.
Fixes #256
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: