Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShiftState value inconsistent with proto #288

Closed
morganofslo opened this issue Jan 2, 2025 · 5 comments
Closed

ShiftState value inconsistent with proto #288

morganofslo opened this issue Jan 2, 2025 · 5 comments

Comments

@morganofslo
Copy link

We are attempting to read ShiftState, however the values we receive don't seem to conform to the defined enum values, which is concerning. For example, instead of 'ShiftStateD', we receive 'D'. This doesn't seem consistent with other enum behaviors; for example, for DetailedChargeState, we receive 'DetailedChargeStateDisconnected' not 'Disconnected'

@agbpatro
Copy link
Collaborator

agbpatro commented Jan 2, 2025

hmm which field are you reading? Value of Gear should be ShiftState enum

@Bre77
Copy link

Bre77 commented Jan 2, 2025

If you add "prefer_typed":true to your vehicle config you get the full value from the ENUM. Without that you only get the bit at the end that changes for all ENUMs.

@rileymd88
Copy link

Just adding that I see the same behaviour. Would be nice to have examples/enums for all fields so we know what to expect

@Bre77
Copy link

Bre77 commented Jan 7, 2025

You can get most of the way there by looking through https://github.com/Teslemetry/tesla-fleet-telemetry/blob/main/protos/vehicle_data.proto

But thats mostly for newer fields rather than the originals.

@patrickdemers6
Copy link
Collaborator

This is the same issue as #256.

I've opened #307 to improve documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants