Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: description for parameter disable_scp_checks does not look correct and looks to be same as parameter disable_workload_monitoring #384

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: description for parameter disable_scp_checks does not look correct and looks to be same as parameter disable_workload_monitoring #384

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87ac2c2
fix: updated rhcs_cluster_classic documentation description for disab…
vamsinm Nov 9, 2023
594c271
fix: added example in generate_example_usages and reverted changes to…
vamsinm Nov 13, 2023
829472d
updated cluster_reosa_classic resource for docs to be auto generated.
vamsinm Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/data-sources/machine_types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ description: |-

List of machine types

## Example Usage

```terraform
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those docs are autogenerated
in order to add an example for a data source/ resource you should add a directory in generate_example_usages like rosa_operator_roles data source and cluster_rosa_classic resource
Then run make generate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bardielle thank you for reviewing. example updated in generate_example_usage

data "rhcs_machine_types" "machine_types" {}
```

<!-- schema generated by tfplugindocs -->
## Schema
Expand Down
2 changes: 1 addition & 1 deletion docs/resources/cluster_rosa_classic.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ resource "rhcs_cluster_rosa_classic" "rosa_sts_cluster" {
- `compute_machine_type` (String) Identifies the machine type used by the default/initial worker nodes, for example `m5.xlarge`. Use the `rhcs_machine_types` data source to find the possible values.
- `default_mp_labels` (Map of String) This value is the default/initial machine pool labels. Format should be a comma-separated list of '{"key1"="value1", "key2"="value2"}'. This list overwrites any modifications made to node labels on an ongoing basis.
- `destroy_timeout` (Number) This value sets the maximum duration in minutes to allow for destroying resources. Default value is 60 minutes.
- `disable_scp_checks` (Boolean) Enables you to monitor your own projects in isolation from Red Hat Site Reliability Engineer (SRE) platform metrics.
- `disable_scp_checks` (Boolean) Indicates if cloud permission checks are disabled when attempting installation of the cluster.
- `disable_waiting_in_destroy` (Boolean) Disable addressing cluster state in the destroy resource. Default value is false, and so a `destroy` will wait for the cluster to be deleted.
- `disable_workload_monitoring` (Boolean) Enables you to monitor your own projects in isolation from Red Hat Site Reliability Engineer (SRE) platform metrics.
- `ec2_metadata_http_tokens` (String) This value determines which EC2 Instance Metadata Service mode to use for EC2 instances in the cluster.This can be set as `optional` (IMDS v1 or v2) or `required` (IMDSv2 only). This feature is available from OpenShift version 4.11.0 and newer.
Expand Down