Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: description for parameter disable_scp_checks does not look correct and looks to be same as parameter disable_workload_monitoring #384

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vamsinm
Copy link
Contributor

@vamsinm vamsinm commented Nov 9, 2023

description for parameter disable_scp_checks does not look correct and looks to be same as parameter disable_workload_monitoring

also added example usage for rhcs_machine_types

#383

…le_scp_checks and added example usage for rhcs_machine_types
Copy link

openshift-ci bot commented Nov 9, 2023

Hi @vamsinm. Thanks for your PR.

I'm waiting for a terraform-redhat member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


```terraform
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those docs are autogenerated
in order to add an example for a data source/ resource you should add a directory in generate_example_usages like rosa_operator_roles data source and cluster_rosa_classic resource
Then run make generate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bardielle thank you for reviewing. example updated in generate_example_usage

Copy link

openshift-ci bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bardielle for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bardielle
Copy link
Member

bardielle commented Nov 26, 2023

@vamsinm thank you for your contribution and helping that provider be more correct

The docs dir is autogenerated from:

  • templates dir, which includes template files (for example the index and guides pages)
  • generate_example_usages for adding example usges
  • The description of each attribute in the data-source/resource file

In order to edit the description of disable_scp_checks you should edit it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants