chore/remove-controller-errors #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ChecksController had mutliple functions which should return errors but no errors were returned. This commit fixes that and cleans up the tests that expected errors to be returned (but were never also used, as no error could ever be returned). Signed-off-by: Bruno Bressi <[email protected]>
puffitos
added
the
area/checks-controller
Removed the unsued error field from the error struct and the error check that is no longer needed.
lvlcn-t
reviewed
Apr 6, 2024
lvlcn-t
approved these changes
Apr 6, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #123
Changes
Removed the errors from the controller functions, as they aren't/ produced at all.
For additional information look at the commits.
Tests done
TODO