Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckController tests have uneeded cases and are missing checks #131

Closed
1 task done
puffitos opened this issue Apr 6, 2024 · 0 comments · Fixed by #132
Closed
1 task done

CheckController tests have uneeded cases and are missing checks #131

puffitos opened this issue Apr 6, 2024 · 0 comments · Fixed by #132
Assignees
Labels
bug Something isn't working housekeeping

Comments

@puffitos
Copy link
Collaborator

puffitos commented Apr 6, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The CheckController has some tests which aren't checking anything and are only running a function, and some test cases are examining states which cannot happen (like registering a duplicate check and removing a non-existing check).

Expected Behavior

Tests only check real states and do check if something happened.

Steps To Reproduce

No response

Relevant logs and/or screenshots, environment information, etc.

No response

Who can address the issue?

Everyone

Anything else?

Pointed out by @lvlcn-t on #130

@puffitos puffitos added bug Something isn't working housekeeping labels Apr 6, 2024
@puffitos puffitos self-assigned this Apr 6, 2024
This was referenced Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working housekeeping
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant