refactor: genericize target manager #122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is the second PR to address #66.
Initially the target manager was built to implement the feature of #30 asap. The manager logic was implemented in a way around the gitlab API interactions. To be able to support other remote state backends for global registration we need to genericize the target manager.
Changes
Pretty much everything is moving and renaming in this PR.
The only thing I've really changed is that the config now has a type which specifies the type of the remote interactor used kind of like we already do for the loader.
The new target manager config looks like this:
I'll change the docs and chart for this later with the last PR regarding #66 that will close the issue.
For additional information look at the commits.
Tests done
Manual e2e tests
Logs
Remote Repository
TODO