feat: handle os signals #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvlcn-t
added
bug
lvlcn-t
requested review from
y-eight,
niklastreml,
puffitos and
eumel8
as code owners
4 tasks
puffitos
reviewed
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To address this conversation #125 (comment)
Changes
We're now handling the os shutdown signals so the sparrow still shuts down, even in case of a controlled shutdown. This also addresses the bug that sparrow instances stay registered on the remote repository even though the sparrow instance doesn't run anymore.
Additionally to that I've adjusted the README to the changes made in #122 and removed the error handling of the (*Sparrow).Run method because it's always non nil.
For additional information look at the commits.
Tests done
TODO