Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sorting in climb() and prune() configurable #271

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Make sorting in climb() and prune() configurable #271

merged 3 commits into from
Jan 7, 2025

Conversation

psss
Copy link
Collaborator

@psss psss commented Jan 6, 2025 •
edited
Loading

Allow users to disable sorting by node names and preserve the order in which child nodes where inserted into the tree.

Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • mention the version
  • include a release note

@psss psss mentioned this pull request Jan 6, 2025
Merged
4 tasks
@psss psss added this to the 1.6 milestone Jan 6, 2025
@psss psss added the base label Jan 6, 2025
LecrisUT
LecrisUT reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@LecrisUT LecrisUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When sort=False it is a bit confusing what order are child nodes created in w.r.t. scatter feature.

docs/features.rst Outdated Show resolved Hide resolved
@psss psss requested a review from LecrisUT January 7, 2025 10:40
@LecrisUT LecrisUT mentioned this pull request Jan 7, 2025
Open
psss added 3 commits January 7, 2025 13:39
@psss
Make sorting in climb() and prune() configurable
20d045d 
Allow users to disable sorting by node names and preserve the
order in which child nodes where inserted into the tree.
@psss
Document the default sorting behaviour
8bb45f6
@psss
Move the new Sort section under Modules
21a2964
@psss psss force-pushed the optional-prune-sort branch from c89892c to 21a2964 Compare January 7, 2025 12:40
@psss psss self-assigned this Jan 7, 2025
@psss psss merged commit baaccc9 into main Jan 7, 2025
12 of 13 checks passed
@psss psss deleted the optional-prune-sort branch January 7, 2025 13:10
@psss psss mentioned this pull request Jan 7, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszachy lukaszachy lukaszachy approved these changes

@KwisatzHaderach KwisatzHaderach KwisatzHaderach approved these changes

@therazix therazix therazix approved these changes

@happz happz Awaiting requested review from happz happz is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

@LecrisUT LecrisUT Awaiting requested review from LecrisUT

Assignees

@psss psss

Labels
base
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@psss @lukaszachy @KwisatzHaderach @LecrisUT @therazix