Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve order of the shell discover tests #3446

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Preserve order of the shell discover tests #3446

merged 2 commits into from
Jan 9, 2025

Conversation

psss
Copy link
Collaborator

@psss psss commented Jan 6, 2025 •
edited
Loading

Tests defined using the shell discover method should be executed in the very same order as listed in the discover step config.

Pull Request Checklist

  • implement the feature
  • extend the test coverage
  • include a release note

@psss psss added this to the 1.41 milestone Jan 6, 2025
@psss psss added step | discover Stuff related to the discover step priority | must high priority, must be included in the next release plugin | fmf The fmf discover plugin ci | full test Pull request is ready for the full test execution labels Jan 6, 2025
@psss psss mentioned this pull request Jan 6, 2025
Merged
4 tasks
@psss psss force-pushed the discover-shell-test-order branch from 1c7a78e to 9014d78 Compare January 6, 2025 17:53
@psss psss force-pushed the discover-shell-test-order branch 2 times, most recently from 190450d to 3ccc137 Compare January 7, 2025 13:31
@psss
Copy link
Collaborator Author

psss commented Jan 7, 2025

/packit test teemtee/fmf#271

@psss psss removed the ci | full test Pull request is ready for the full test execution label Jan 7, 2025
@psss
Copy link
Collaborator Author

psss commented Jan 7, 2025

/packit test teemtee/fmf#271

@psss psss force-pushed the discover-shell-test-order branch 2 times, most recently from 6d1f365 to 674bf61 Compare January 8, 2025 09:14
@psss psss added the ci | full test Pull request is ready for the full test execution label Jan 8, 2025
psss added 2 commits January 9, 2025 00:03
@psss
Preserve order of the shell discover tests
6d5750b 
Tests defined using the `shell` discover method should be executed
in the very same order as listed in the discover step config.
@psss
Require fresh fmf with the sort support
b4c6b39
@psss psss force-pushed the discover-shell-test-order branch from 674bf61 to b4c6b39 Compare January 8, 2025 23:03
@psss psss self-assigned this Jan 9, 2025
@psss psss merged commit b31b078 into main Jan 9, 2025
19 of 20 checks passed
@psss psss deleted the discover-shell-test-order branch January 9, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@seberm seberm seberm approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

Assignees

@psss psss

Labels
ci | full test Pull request is ready for the full test execution plugin | fmf The fmf discover plugin priority | must high priority, must be included in the next release step | discover Stuff related to the discover step
Projects
None yet
Milestone
1.41
Development

Successfully merging this pull request may close these issues.
3 participants
@psss @happz @seberm