Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Add pre-compile: verification for ed25519 sig made via GPG #2

Open
wants to merge 11 commits into
base: optimism
Choose a base branch
from
Open

(WIP) Add pre-compile: verification for ed25519 sig made via GPG #2

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
67bd272
add gpg-ed25519
nkrishang Dec 25, 2024
cbc7d3a
Add tests
nkrishang Dec 26, 2024
051364b
Return bytes32(0) for verification failure
nkrishang Dec 27, 2024
528401f
bypass public key expiration check
nkrishang Dec 27, 2024
72aaf0b
precompile expects dearmored bytes inputs
nkrishang Dec 27, 2024
8b33d68
limit message size to 32 bytes
nkrishang Dec 27, 2024
d3c407b
update expected input abi encoding
nkrishang Dec 27, 2024
cdf66f7
input is abi.encode not abi.encodePacked
nkrishang Dec 28, 2024
4e8cd56
decode using /abi
nkrishang Dec 28, 2024
72d0145
move decode into helper func
zobront Dec 28, 2024
c08cefc
Update gas for gpgEd25519Verify
nkrishang Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion params/protocol_params.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ const (
Bls12381MapG2Gas uint64 = 75000 // Gas price for BLS12-381 mapping field element to G2 operation

P256VerifyGas uint64 = 3450 // secp256r1 elliptic curve signature verifier gas price
GpgEd25519VerifyGas uint64 = 2000 // GPG Ed25519 signature verification gas price
GpgEd25519VerifyGas uint64 = 7900 // GPG Ed25519 signature verification gas price
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming Ecrecover is fairly priced (as per EIP-152 Blake2 precompile) at 3000 gas/op for ~50,100 ns/op.

GpgEd25519Verify should be priced proportionately 7900 gas/op for ~134,000 ns/op as a good first estimate for gas cost.


// The Refund Quotient is the cap on how much of the used gas can be refunded. Before EIP-3529,
// up to half the consumed gas could be refunded. Redefined as 1/5th in EIP-3529
Expand Down