forked from ethereum-optimism/op-geth
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPG Verification Precompile #2
Merged
+283
−20
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d5dbfcf
core: Move blockchain head verification after possible rewind (op-get…
sebastianst efa05b1
update superchain dependency (#450)
geoknee 67bd272
add gpg-ed25519
nkrishang cbc7d3a
Add tests
nkrishang 051364b
Return bytes32(0) for verification failure
nkrishang 528401f
bypass public key expiration check
nkrishang 72aaf0b
precompile expects dearmored bytes inputs
nkrishang 8b33d68
limit message size to 32 bytes
nkrishang d3c407b
update expected input abi encoding
nkrishang cdf66f7
input is abi.encode not abi.encodePacked
nkrishang 4e8cd56
decode using /abi
nkrishang 72d0145
move decode into helper func
zobront c08cefc
Update gas for gpgEd25519Verify
nkrishang 1877192
include key id in verification, add test for rsa"
zobront ec0fc3b
nit
zobront faa2a72
merge in nk gas change
zobront 36e9819
precompile in IsTea only, testing
zobront File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
precompile expects dearmored bytes inputs
commit 72aaf0b4a774cb4326454b07133373b3f1ff3106
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific length the pubKey is supposed to be that we should verify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to the comment on signature length. The armored public key length is non-deterministic (exported via
gpg --export --armor <your-key-id>
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, no way to do this. I'm going to leave this comment open as a reminder that I need to talk to the Tea team to figure out a reasonable upper bound to make sure that (a) there is sufficient gas to handle it, and (b) that there is no DOS risk based on whatever gas params we choose.