Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix completed scenario to show green status #2312

Merged
merged 3 commits into from
Feb 8, 2025
Merged

Fix completed scenario to show green status #2312

merged 3 commits into from
Feb 8, 2025

Conversation

xsebek
Copy link
Member

@xsebek xsebek commented Feb 8, 2025

  • add lenses to a Metric
  • decide completion status based on best record (either one will do)
Screenshot 2025-02-08 at 3 33 27 PM

@xsebek xsebek requested review from kostmo and byorgey February 8, 2025 14:34
@github-actions github-actions bot mentioned this pull request Feb 8, 2025
Merged
byorgey
byorgey approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I like the new lenses too.

@xsebek xsebek added the merge me Trigger the merge process of the Pull request. label Feb 8, 2025
@mergify mergify bot merged commit 3039720 into main Feb 8, 2025
12 checks passed
@mergify mergify bot deleted the fix/xsebek/green-completed branch February 8, 2025 15:19
@xsebek xsebek mentioned this pull request Feb 8, 2025
Closed
@byorgey
Copy link
Member

byorgey commented Feb 8, 2025

Hmm, actually, this doesn't seem to be working correctly for me. After pulling this into main and building, it looks like I lost all my progress on the tutorials --- all are drawn with unfilled circles. My progress is still saved, though, and if I switch back to a different branch the progress is shown correctly again.

xsebek added a commit that referenced this pull request Feb 9, 2025
@xsebek
Make Metric JSON format backward compatible
fb781e0 
The change in #2312 mistakenly broke compatibility.
This customizes the JSON format and supports the original one.
This was referenced Feb 9, 2025
Merged
Closed
mergify bot pushed a commit that referenced this pull request Feb 9, 2025
@xsebek
Make Metric JSON format backward compatible (#2318)
29e9105 
The change in #2312 mistakenly broke scenario "save" (best score) compatibility.
This customizes the JSON format and supports the original one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

@kostmo kostmo Awaiting requested review from kostmo

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xsebek @byorgey