Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dot shown next to scenario should depend on *best* play, not *most recent* #2311

Closed
byorgey opened this issue Feb 7, 2025 · 3 comments
Closed
Assignees
Labels
C-Low Hanging Fruit Ideal issue for new contributors. T-UI Involves the user interface. Z-Feature A new feature to be added to the game.

Comments

@byorgey
Copy link
Member

byorgey commented Feb 7, 2025

When I have completed a scenario I expect the dot next to it to be green, and stay green forever. I don't expect it to go back to an unfilled yellow circle just because I started replaying the scenario but didn't finish --- I have still completed it in the past.

@kostmo did you have a specific reason for making it work the way it does (I think it was you who wrote that code, right)?

@byorgey byorgey added C-Low Hanging Fruit Ideal issue for new contributors. T-UI Involves the user interface. Z-Feature A new feature to be added to the game. labels Feb 7, 2025
@xsebek
Copy link
Member

xsebek commented Feb 8, 2025

Who could have made such an oversight? 😠

Huh, well, I don't remember what I was thinking. 😆

I will push a fix shortly.

@xsebek xsebek self-assigned this Feb 8, 2025
@byorgey
Copy link
Member Author

byorgey commented Feb 8, 2025

@kostmo apologies for insulting your judgment 😅

@xsebek
Copy link
Member

xsebek commented Feb 8, 2025

Closed by #2312.

@xsebek xsebek closed this as completed Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Low Hanging Fruit Ideal issue for new contributors. T-UI Involves the user interface. Z-Feature A new feature to be added to the game.
Projects
None yet
Development

No branches or pull requests

2 participants