✨(front) add virtual backgrounds + improve effects modal ! #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanVss
force-pushed
the
feat/background-effects
branch
5 times, most recently
from
3d918b2 to
0c8dcc3
Compare
This is a wrapper around track-processor-js virtual background processor. This is needed in order to be used in a generic way in our code between firefox processors.
NathanVss
force-pushed
the
feat/background-effects
branch
from
0c8dcc3 to
fb2f75c
Compare
NathanVss
changed the title
BackgroundBlurCustomProcessor is renamed to BackgroundCustomProcessor in order to reflect the fact that is now handles virtual backgrounds too. BackgroundBlurFactory is also renamed to BackgroundProcessorFactory. The processor serialization handling has also been updated in order to support various options, also if persisted in local storage.
This new ui implement the new sketches and also enables the usage of virtual background in a nice way.
NathanVss
force-pushed
the
feat/background-effects
branch
from
fb2f75c to
3adb5a8
Compare
lebaudantoine
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Proposal
Mon.film.1.mp4
Todo