-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add version and compose check to workflow #50
Closed
Closed
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5871af4
ENH: Add version and compose check to workflow
khalford 3279c28
BUG: branch is master not main
khalford 264465b
MAINT: Track dev not main to follow changes
khalford d331486
BUG: Try absolute paths
khalford b0f913e
revert changes
khalford 3936696
ENH: Tidy workflow
khalford 7caa8bf
MAINT: Bump version
khalford 3abd705
MAINT: Change to STFC repo
khalford 6f823d7
MAINT: Bump versions
khalford 4c1e2de
DOC: Update template config
khalford 77acbd5
DOC: Updates to readme
khalford 7784269
Merge branch 'master' into add_compose_check_action
khalford 6ac6187
Merge pull request #59 from stfc/edit_template
khalford 9fe8b43
ENH: Add version and compose check to workflow
khalford eb99ac3
BUG: branch is master not main
khalford 1818c4b
MAINT: Track dev not main to follow changes
khalford b5abe8d
BUG: Try absolute paths
khalford 0060c48
revert changes
khalford 5d89152
ENH: Tidy workflow
khalford 322d2fb
MAINT: Change to STFC repo
khalford 136cf08
Merge remote-tracking branch 'origin/add_compose_check_action' into a…
khalford File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
services: | ||
cloud_chatops: | ||
image: harbor.stfc.ac.uk/stfc-cloud/cloud-chatops:1.1.0 | ||
image: harbor.stfc.ac.uk/stfc-cloud/cloud-chatops:2.0.2 | ||
volumes: | ||
- $HOME/cloud_chatops_secrets/:/usr/src/app/cloud_chatops_secrets/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,13 @@ | ||
--- | ||
maintainer: AB12CD34 # Slack Member ID of the application maintainer | ||
maintainer: <maintainers_member_id> | ||
|
||
user-map: # Dictionary of GitHub username to Slack Member ID | ||
my_github_username: AB12CD34 | ||
other_github_username: EF56GH78 | ||
user-map: | ||
<user_github_username>: <user_member_id> | ||
|
||
repos: # Dictionary of owners and repositories | ||
organisation1: | ||
- repo1 # E.g. github.com/organisation1/repo1 | ||
- repo2 | ||
- repo3 | ||
organisation2: | ||
- repo1 # E.g. github.com/organisation2/repo1 | ||
- repo2 | ||
- repo3 | ||
repos: | ||
<organisation>: | ||
- <repo> | ||
|
||
defaults: # Default values for application variables | ||
# Default author will be assigned to pull requests where the PR author is not in the above user map. | ||
# Usually team lead or senior staff member. | ||
author: WX67YZ89 # Slack member ID | ||
|
||
# Default channel is where the pull requests will be posted. | ||
# It's recommended to set this as a "maintenance" / "dev" channel in case the application goes awry. | ||
# The actual channel messages are sent to can be specified in the code. | ||
channel: CH12NN34 # Slack channel ID | ||
defaults: | ||
author: <author_member_id> | ||
channel: <reminder_channel_id> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
2.0.1 | ||
2.0.2 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version is also being used in this open PR: #59 - which PR needs to be reviewed and merged first to use this version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left them both as the same version. When one of them (either) is merged then the other will be rebased and updated. If I were to change this PR to 2 versions ahead (2.0.3) there would be a chance of a version being skipped.