Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add version and compose check to workflow #50

Closed
wants to merge 21 commits into from
Closed

ENH: Add version and compose check to workflow #50

wants to merge 21 commits into from

Conversation

khalford
Copy link
Member

@khalford khalford commented Oct 2, 2024 •
edited
Loading

Adding an action to check if the version.txt is updated correctly not just changed. Also, checks if the docker-compose.yml matches version.txt

DavidFair
DavidFair requested changes Oct 3, 2024
View reviewed changes
.github/workflows/cloud_chatops.yaml Outdated Show resolved Hide resolved
@khalford khalford requested a review from DavidFair October 7, 2024 12:06
DavidFair
DavidFair previously approved these changes Oct 21, 2024
View reviewed changes
@khalford
Copy link
Member Author

khalford commented Oct 23, 2024 •
edited
Loading

Waiting on stfc/check-version-action#1 for the action to be merged. Then this PR can be merged.

EDIT: PR now merged, no longer waiting

@khalford
MAINT: Bump versions
6f823d7 
This also includes updating the compose file from a previous update that was forgotten
@khalford
DOC: Update template config
4c1e2de 
The template config does not need comments as the config is explained in the readme
@khalford
DOC: Updates to readme
77acbd5
@khalford khalford added the patch Semver patch change label Oct 23, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (eb9d469) to head (136cf08).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files          12       12           
  Lines         608      608           
=======================================
  Hits          600      600           
  Misses          8        8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meoflynn meoflynn mentioned this pull request Nov 4, 2024
Merged
meoflynn
meoflynn reviewed Nov 4, 2024
View reviewed changes
cloud-chatops/version.txt
@@ -1 +1 @@
2.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version is also being used in this open PR: #59 - which PR needs to be reviewed and merged first to use this version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left them both as the same version. When one of them (either) is merged then the other will be rebased and updated. If I were to change this PR to 2 versions ahead (2.0.3) there would be a chance of a version being skipped.

@khalford
Merge pull request #59 from stfc/edit_template
6ac6187 
Small documentation improvments
@khalford khalford added minor Semver minor change and removed patch Semver patch change labels Nov 5, 2024
@khalford
Copy link
Member Author

khalford commented Nov 5, 2024

Closing due to messy git history when rebasing. Remade into #61

@khalford khalford closed this Nov 5, 2024
@khalford khalford deleted the add_compose_check_action branch November 5, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meoflynn meoflynn meoflynn approved these changes

@DavidFair DavidFair Awaiting requested review from DavidFair

Assignees
No one assigned
Labels
minor Semver minor change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khalford @DavidFair @meoflynn