Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict best LC update collection to canonical blocks #5613

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

etan-status
Copy link
Contributor

Simplify best LightClientUpdate collection by tracking only canonical data instead of tracking the best update across all branches within the sync committee period.

Simplify best `LightClientUpdate` collection by tracking only canonical
data instead of tracking the best update across all branches within the
sync committee period.

- ethereum/consensus-specs#3553
Copy link

Unit Test Results

         9 files  ±0    1 098 suites  ±0   27m 22s ⏱️ -12s
  3 951 tests ±0    3 604 ✔️ ±0  347 💤 ±0  0 ±0 
16 066 runs  ±0  15 668 ✔️ ±0  398 💤 ±0  0 ±0 

Results for commit cc2bb10. ± Comparison against base commit 375f276.

@etan-status etan-status merged commit c33dd2c into unstable Nov 21, 2023
8 checks passed
@etan-status etan-status deleted the dev/etan/lc-canonical branch November 21, 2023 22:51
@jakubgs
Copy link
Member

jakubgs commented Nov 22, 2023

This PR looks like the most likely culprit for this crash which is present on all our unstable nodes on Holesky testnet:

../csu/libc-start.c(392)
../sysdeps/nptl/libc_start_call_main.h(58)
..../vendor/nim-libp2p/libp2p/protocols/rendezvous.nim(902) main
..../vendor/nim-libp2p/libp2p/protocols/rendezvous.nim(895) NimMain
..../beacon_chain/nimbus_beacon_node.nim(2346) main
..../beacon_chain/nimbus_beacon_node.nim(2214) handleStartUpCmd
..../beacon_chain/nimbus_beacon_node.nim(2102) doRunBeaconNode
..../beacon_chain/nimbus_beacon_node.nim(521) init
..../vendor/nim-chronos/chronos/internal/asyncfutures.nim(359) futureContinue
..../beacon_chain/nimbus_beacon_node.nim(717) init
..../beacon_chain/nimbus_beacon_node.nim(241) loadChainDag
..../beacon_chain/consensus_object_pools/blockchain_dag.nim(1131) init
..../vendor/nimbus-build-system/vendor/Nim/lib/system/assertions.nim(38) failedAssertImpl
..../vendor/nimbus-build-system/vendor/Nim/lib/system/assertions.nim(28) raiseAssert
..../vendor/nimbus-build-system/vendor/Nim/lib/system/fatal.nim(54) sysFatal
[[reraised from:
../csu/libc-start.c(392)
../sysdeps/nptl/libc_start_call_main.h(58)
..../vendor/nim-libp2p/libp2p/protocols/rendezvous.nim(902) main
..../vendor/nim-libp2p/libp2p/protocols/rendezvous.nim(895) NimMain
..../beacon_chain/nimbus_beacon_node.nim(2346) main
..../beacon_chain/nimbus_beacon_node.nim(2214) handleStartUpCmd
..../beacon_chain/nimbus_beacon_node.nim(2102) doRunBeaconNode
..../beacon_chain/nimbus_beacon_node.nim(521) init
..../vendor/nim-chronos/chronos/internal/asyncfutures.nim(359) futureContinue
..../beacon_chain/nimbus_beacon_node.nim(845) init
]]
Error: unhandled exception: ..../beacon_chain/consensus_object_pools/blockchain_dag.nim(1131, 12) `dag.finalizedHead.blck.parent == nil` ...but that's the last BlockRef with a parent [AssertionDefect]

@jakubgs
Copy link
Member

jakubgs commented Nov 22, 2023

Correction: I found a Prater node affected on: unstable-large-01.aws-eu-central-1a.nimbus.prater

@etan-status
Copy link
Contributor Author

This PR looks like the most likely culprit for this crash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants