Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm unused code #5623

Merged
merged 1 commit into from
Nov 25, 2023
Merged

rm unused code #5623

merged 1 commit into from
Nov 25, 2023

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Nov 25, 2023

All found by XDeclaredButNotUsed

@github-actions GitHub Actions
Copy link

Unit Test Results

         9 files  ±0    1 098 suites  ±0   27m 33s ⏱️ -6s
  3 952 tests ±0    3 605 ✔️ ±0  347 💤 ±0  0 ❌ ±0 
16 069 runs  ±0  15 671 ✔️ ±0  398 💤 ±0  0 ❌ ±0 

Results for commit fa736b0. ± Comparison against base commit 5aa595f.

etan-status
etan-status approved these changes Nov 25, 2023
View reviewed changes
Copy link
Contributor

@etan-status etan-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup. the LC code is indeed obsolete since #5613 ; forgot to remove this piece back then.

@tersec tersec merged commit 115ffa7 into unstable Nov 25, 2023
8 checks passed
@tersec tersec deleted the 7RV branch November 25, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etan-status etan-status etan-status approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tersec @etan-status