Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More specific STAC_IO deprecation warnings #449

Merged
merged 3 commits into from
Jun 16, 2021

Conversation

duckontheweb
Copy link
Contributor

Related Issue(s):

Description:

Moved this out of #443 so we can integrate it separately. Also added a Deprecated section to the 1.0.0-beta.1 CHANGELOG section so that the deprecation is more obvious there.

PR Checklist:

  • Code is formatted (run pre-commit run --all-files)
  • Tests pass (run scripts/test)
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@duckontheweb duckontheweb requested a review from lossyrob June 16, 2021 12:34
@duckontheweb duckontheweb linked an issue Jun 16, 2021 that may be closed by this pull request
@duckontheweb duckontheweb added this to the 1.0.0-rc.1 milestone Jun 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2021

Codecov Report

Merging #449 (f832683) into main (e7d4bdc) will increase coverage by 0.09%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
+ Coverage   90.67%   90.76%   +0.09%     
==========================================
  Files          40       40              
  Lines        5105     5113       +8     
==========================================
+ Hits         4629     4641      +12     
+ Misses        476      472       -4     
Impacted Files Coverage Δ
pystac/stac_io.py 76.71% <90.90%> (+4.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7d4bdc...f832683. Read the comment docs.

@duckontheweb duckontheweb merged commit e73c570 into stac-utils:main Jun 16, 2021
@duckontheweb duckontheweb deleted the deprecate/gh-431-stac-io branch June 16, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Remove deprecated STAC_IO class
3 participants