Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Remove deprecated STAC_IO class #431

Closed
duckontheweb opened this issue Jun 11, 2021 · 1 comment · Fixed by #449
Closed

RFC: Remove deprecated STAC_IO class #431

duckontheweb opened this issue Jun 11, 2021 · 1 comment · Fixed by #449
Assignees
Labels
discussion An issue to capture a discussion

Comments

@duckontheweb
Copy link
Contributor

After #309 the STAC_IO class was deprecated in favor of StacIO. The v1.0.0 release seems like a good time to remove STAC_IO from the code base so we are not starting a new major release with a deprecated feature.

I propose that we add more specific deprecation notices to STAC_IO and its methods in v1.0.0-rc.1 that indicate its removal in v1.0.0, and that we remove the class entirely in v1.0.0.

The purpose of this issue is to get feedback on this proposal. It would also be good to hear about any changes that need to be made to StacIO to make the transition smoother, especially for maintainers of other libraries that have PySTAC as a dependency.

cc: @gadomski @matthewhanson @lossyrob

@duckontheweb duckontheweb added the discussion An issue to capture a discussion label Jun 11, 2021
@matthewhanson
Copy link
Member

I'm +1 on not having a deprecated class in a v1.0.0 release. I think that any dependent library, when updating it's dependency to PySTAC 1.0.0, should be updated itself to use the new StacIO class.

@duckontheweb duckontheweb self-assigned this Jun 16, 2021
@duckontheweb duckontheweb linked a pull request Jun 16, 2021 that will close this issue
4 tasks
duckontheweb pushed a commit that referenced this issue Jun 16, 2021
More specific STAC_IO deprecation warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion An issue to capture a discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants