revert max_items to default to None (retrieve all items) #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #278 +/- ##
=======================================
Coverage 83.54% 83.54%
=======================================
Files 10 10
Lines 717 717
=======================================
Hits 599 599
Misses 118 118
Continue to review full report at Codecov.
|
|
There's already #273. Should I close that in favor of this? |
| @@ -76,7 +76,7 @@ | |||
|
|
|||
| OPS = list(OP_MAP.keys()) | |||
|
|
|||
| DEFAULT_LIMIT_AND_MAX_ITEMS = 100 | |||
| DEFAULT_LIMIT = 100 | |||
There was a problem hiding this comment.
Technically should alias this, since DEFAULT_LIMIT_AND_MAX_ITEMS is in the public API.
|
Closed in favor of #273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Revert max_items to default to None instead of 100, so all items are retrived.
PR Checklist: