-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore default max_items behavior #273
Conversation
xref stac-utils#237 (comment) Doesn't close that issue, which also deals with the replacement for the deprecated methods. This just reverts the change to the default `max_items` to return all matching items by default.
Codecov Report
@@ Coverage Diff @@
## main #273 +/- ##
=======================================
Coverage 83.54% 83.54%
=======================================
Files 10 10
Lines 717 717
=======================================
Hits 599 599
Misses 118 118
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok w/ this as a MINOR change to incorporate it in a v0.4.1 release. @TomAugspurger do you have a definitive document(s) that describe what constitutes MAJOR, MINOR, and PATCH changes in Python APIs, ala https://doc.rust-lang.org/cargo/reference/semver.html?
There's no general versioning guidelines in Python. It's up to the project to document its versioning policy, and how that relates to deprecations and compatability |
xref #237 (comment)
Doesn't close that issue, which also discusses the replacement for the
deprecated methods. This just reverts the change to the default
max_items
to return all matching items by default.