Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a knob to initiate webhook deletion checks for ip resources #4675

Merged
merged 1 commit into from
Feb 22, 2025

Add a knob to initiate webhook deletion checks for ip resources

f649572
Select commit
Loading
Failed to load commit list.
Merged

Add a knob to initiate webhook deletion checks for ip resources #4675

Add a knob to initiate webhook deletion checks for ip resources
f649572
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 21, 2025 in 0s

75.38% (target 60.00%)

View this Pull Request on Codecov

75.38% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.38%. Comparing base (285e341) to head (f649572).

Files with missing lines Patch % Lines
pkg/podmanager/pod_webhook.go 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4675      +/-   ##
==========================================
- Coverage   75.52%   75.38%   -0.14%     
==========================================
  Files          56       56              
  Lines        6810     6816       +6     
==========================================
- Hits         5143     5138       -5     
- Misses       1449     1466      +17     
+ Partials      218      212       -6     
Files with missing lines Coverage Δ
pkg/ippoolmanager/ippool_webhook.go 90.62% <100.00%> (+8.90%) ⬆️
pkg/subnetmanager/subnet_webhook.go 90.62% <100.00%> (+8.90%) ⬆️
pkg/podmanager/pod_webhook.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes