Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a knob to initiate webhook deletion checks for ip resources #4675

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

cyclinder
Copy link
Collaborator

@cyclinder cyclinder commented Feb 20, 2025

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #4672

Special notes for your reviewer:

添加 enableValidatingResourcesDeletedWebhook 控制删除 IPPool 和 Subnet 资源时,是否 webhook 校验当前 IP 池或 Subnet 存在已分配 IP。

Add enableValidatingResourcesDeletedWebhook to control whether or not the webhook verifies the existence of assigned IPs in the current IP pool or Subnet when deleting IPPool and Subnet resources.

@cyclinder cyclinder added the release/feature-changed release note for changed feature label Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.38%. Comparing base (285e341) to head (f649572).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/podmanager/pod_webhook.go 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4675      +/-   ##
==========================================
- Coverage   75.52%   75.38%   -0.14%     
==========================================
  Files          56       56              
  Lines        6810     6816       +6     
==========================================
- Hits         5143     5138       -5     
- Misses       1449     1466      +17     
+ Partials      218      212       -6     
Flag Coverage Δ
unittests 75.38% <61.53%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/ippoolmanager/ippool_webhook.go 90.62% <100.00%> (+8.90%) ⬆️
pkg/subnetmanager/subnet_webhook.go 90.62% <100.00%> (+8.90%) ⬆️
pkg/podmanager/pod_webhook.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@cyclinder cyclinder force-pushed the ci/webhook_delete branch 9 times, most recently from 2b21773 to 2705a24 Compare February 21, 2025 07:22
@cyclinder cyclinder merged commit 2985144 into spidernet-io:main Feb 22, 2025
55 checks passed
@cyclinder cyclinder deleted the ci/webhook_delete branch February 22, 2025 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/feature-changed release note for changed feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Night CI 2025-02-18: Failed
1 participant