-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
synchronize clusterIP CIDR from serviceCIDR to support k8s 1.29 #3132
synchronize clusterIP CIDR from serviceCIDR to support k8s 1.29 #3132
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3132 +/- ##
==========================================
+ Coverage 81.07% 81.13% +0.05%
==========================================
Files 50 50
Lines 5358 5358
==========================================
+ Hits 4344 4347 +3
+ Misses 856 854 -2
+ Partials 158 157 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
820f5f4
to
44c200b
Compare
in the PR description, could you attach a yaml example of servicecidr to show what it looks like for reference |
for a new feature, it should add some explanation. |
0bfa8e5
to
2aed06a
Compare
5081b9e
to
d782a64
Compare
5cec15f
to
e687fb8
Compare
c59c3eb
to
cc91f6a
Compare
it could be sync service cidr to spidercoordinator from serviceCIDR in k8s 1.29 Signed-off-by: cyclinder <[email protected]>
92a703b
to
b5890bb
Compare
该 PR 似乎会导致 k8s 矩阵(1.22、1.23、1.24等版本)失败 ?是否只能在 1.29 版本的 K8S 上运行? |
是的,e2e 只能在 1.29 以上跑 |
Signed-off-by: cyclinder <[email protected]>
b5890bb
to
0628e63
Compare
it could be sync service cidr to spidercoordinator from serviceCIDR in k8s 1.29
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Refer to https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/1880-multiple-service-cidrs/README.md, kubernetes can allocate service ips from serviceCIDR resources in 1.29.
This PR synchronizes the service cidr from the
serviceCIDR
resource to the spidercoordinator. If the resource cannot be found or there are any errors, then we will fall back to the default behavior (from kubeadm-config and kube-controller-manager).Which issue(s) this PR fixes:
Fixes #2905
Special notes for your reviewer: