-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable coordinate to support serviceCIDR according to a matched k8s version. #3168
Conversation
在 PR #3132 中对 MultiCIDRService 功能进行了适配。但该功能门是在 kubernetes 1.27 版本引入的,1.29 版本 GA。故在 1.27 之前的版本中,该功能并不可用,开启该功能将导致多矩阵的 K8s(低于 1.27.0 的) 运行 setup kind cluster 失败。对此做了适配。如果 kubernetes 版本是 1.29 及以上的版本,才开启该功能并运行对应 e2e。 /cc @cyclinder please help review it. |
@@ -18,7 +18,3 @@ kubeadmConfigPatches: | |||
nodes: | |||
- role: control-plane | |||
- role: worker | |||
featureGates: | |||
"MultiCIDRServiceAllocator": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以这样 {"AllAlpha":true}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
然后上面 makefile 就不用动了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我担心以后要是还有别的feature-gate 添加,会导致 makefile 变得无比冗长
@@ -18,7 +18,3 @@ kubeadmConfigPatches: | |||
nodes: | |||
- role: control-plane | |||
- role: worker | |||
featureGates: | |||
"MultiCIDRServiceAllocator": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
然后上面 makefile 就不用动了
/hold 仍需要更多测试 |
6c31a5b
to
974a76d
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3168 +/- ##
==========================================
- Coverage 81.68% 81.12% -0.56%
==========================================
Files 50 50
Lines 5373 5373
==========================================
- Hits 4389 4359 -30
- Misses 823 856 +33
+ Partials 161 158 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
fix #3180 |
给cilium先回退一个版本 |
在 IPv6 模式下,v 1.15.0 版本的 cilium Pod 报错。
查看文档 https://docs.cilium.io/en/stable/network/concepts/routing/ 暂时做修改。
|
Signed-off-by: ty-dc <[email protected]>
from the PR title, there is no idea what it is |
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3163
Special notes for your reviewer: