Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancellation tests #218

Merged
merged 29 commits into from
Jan 30, 2025
Merged

Add cancellation tests #218

merged 29 commits into from
Jan 30, 2025

Conversation

adamhathcock
Copy link
Member

requires #216

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 88.84540% with 57 lines in your changes missing coverage. Please review.

Project coverage is 70.62%. Comparing base (f0c7169) to head (d1350d5).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...Sdk.Serialization.Tests/Framework/TestTransport.cs 20.00% 8 Missing ⚠️
...peckle.Sdk/Serialisation/V2/Send/BaseSerializer.cs 80.00% 5 Missing and 1 partial ⚠️
...zation.Tests/DummyCancellationSqLiteSendManager.cs 25.00% 6 Missing ⚠️
...k.Serialization.Tests/Framework/TestFileManager.cs 77.77% 3 Missing and 3 partials ⚠️
...zation.Tests/CancellationSqLiteJsonCacheManager.cs 73.33% 4 Missing ⚠️
Speckle.Sdk.Testing/Framework/ExceptionScrubber.cs 75.00% 2 Missing and 1 partial ⚠️
...c/Speckle.Sdk/Api/Operations/Operations.Receive.cs 0.00% 3 Missing ⚠️
.../Speckle.Sdk.Serialization.Tests/ExceptionTests.cs 93.02% 0 Missing and 3 partials ⚠️
...ation.Tests/Framework/ExceptionSendCacheManager.cs 66.66% 3 Missing ⚠️
...e.Sdk/Serialisation/V2/Receive/BaseDeserializer.cs 60.00% 1 Missing and 1 partial ⚠️
... and 10 more
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #218       +/-   ##
===========================================
+ Coverage   58.07%   70.62%   +12.55%     
===========================================
  Files         251      278       +27     
  Lines       10083    11120     +1037     
  Branches     1089     1102       +13     
===========================================
+ Hits         5856     7854     +1998     
+ Misses       3971     2914     -1057     
- Partials      256      352       +96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock adamhathcock marked this pull request as ready for review January 28, 2025 11:19
@adamhathcock adamhathcock enabled auto-merge (squash) January 28, 2025 11:29
@adamhathcock adamhathcock merged commit 3aa993c into dev Jan 30, 2025
4 checks passed
@adamhathcock adamhathcock deleted the add-cancellation-tests branch January 30, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants